Move commentstring to ftplugin #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-ebot7
approved these changes
Jul 25, 2020
andys8
added a commit
to andys8/dotfiles
that referenced
this pull request
Jul 25, 2020
Until <purescript-contrib/purescript-vim#68> is merged
Member
|
This looks good to me, and I think should be merged. |
andys8
approved these changes
Oct 6, 2020
thomashoneyman
approved these changes
Oct 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard practice is to put commentstring inside ftplugin, not ftdetect.
I've also changed it to inline comment, as in #59